Linux Sound subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: phucduc.bui@gmail.com
Cc: linux-sound@vger.kernel.org
Subject: Re: [PATCH 2/2] ASoC: atmel: mchp-spdiftx: Mark interrupt registers as volatile
Date: Fri, 20 Nov 2026 10:10:29 +0000	[thread overview]
Message-ID: <sashiko-outbox-224911@kernel.org> (raw)
In-Reply-To: <20261120100408.8053-3-phucduc.bui@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ASoC: atmel: mchp-spdiftx: inaccurate Fixes trailer
--

commit 8b049b6663dc075bd7b0f48f483d1e20b6fe30c6
Author: bui duc phuc <phucduc.bui@gmail.com>

> ASoC: atmel: mchp-spdiftx: Mark interrupt registers as volatile
>
> The interrupt handler reads ISR and IMR to determine which interrupts
> are pending. Neither register is marked as volatile, causing regmap
> to return cached values instead of reading the hardware.
>
> Add a volatile_reg callback marking IMR and ISR as volatile.
>
> Fixes: 06ca24e98e6b ("ASoC: mchp-spdiftx: add driver for S/PDIF TX Controller")
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>

[Severity: Low]
In commit 06ca24e98e6b ("ASoC: mchp-spdiftx: add driver for S/PDIF TX
Controller"), mchp_spdiftx_regmap_config left .cache_type unset
(REGCACHE_NONE), so regmap_read() read SPDIFTX_ISR and SPDIFTX_IMR
directly from hardware.  Regmap caching was enabled later in commit
4bf54ca60f99 ("ASoC: mchp-spdiftx: add runtime pm support"), which added
.cache_type = REGCACHE_FLAT without a .volatile_reg callback.

Should the Fixes tag reference that commit instead?

  Fixes: 4bf54ca60f99 ("ASoC: mchp-spdiftx: add runtime pm support")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120100408.8053-1-phucduc.bui@gmail.com?part=2

      reply	other threads:[~2026-11-20 10:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 10:04 [PATCH 0/2] ASoC: atmel: Mark interrupt registers as volatile phucduc.bui
2026-11-20 10:04 ` [PATCH 1/2] ASoC: atmel: mchp-pdmc: Mark IMR " phucduc.bui
2026-11-20 10:16   ` sashiko-bot
2026-11-20 10:04 ` [PATCH 2/2] ASoC: atmel: mchp-spdiftx: Mark interrupt registers " phucduc.bui
2026-11-20 10:10   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-224911@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=phucduc.bui@gmail.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox