Linux Sound subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Jizhou Tong" <fqwqf@fqwqf.xyz>
Cc: linux-sound@vger.kernel.org
Subject: Re: [PATCH] ASoC: codecs: wcd-common: bound interrupt status retries
Date: Sun, 22 Nov 2026 06:30:35 +0000	[thread overview]
Message-ID: <sashiko-outbox-227766@kernel.org> (raw)
In-Reply-To: <010601a201ee018c-30715d0f-712e-4181-9dea-d1b82b234831-000000@ap-northeast-1.amazonses.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ASoC: wcd-common: missing Fixes: trailer for
  wcd_interrupt_callback() fix
--

commit 138bed245490e607222eb10428e4dada43820030
Author: Jizhou Tong <fqwqf@fqwqf.xyz>

> ASoC: codecs: wcd-common: bound interrupt status retries
>
> wcd_interrupt_callback() reads three status registers after dispatching
> the codec interrupt. It ignores read errors, so the loop condition can
> use an uninitialized value or a value from the previous pass. A status
> bit that stays set can also keep the callback looping while SoundWire
> holds sdw_dev_lock.
>
> Return on the first failed read. Allow up to ten dispatches for status
> to clear, matching the SoundWire alert handler's retry budget. If a bit
> remains set, log a rate-limited error and return -ETIMEDOUT.
>
> Signed-off-by: Jizhou Tong <fqwqf@fqwqf.xyz>

[Severity: Low]
This fixes the unchecked regmap_read() calls and unbounded retry loop in
wcd_interrupt_callback().  Should it include:

  Fixes: 59aebbbb0b47 ("ASoC: codecs: wcd-common: move status_update callback to common")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/010601a201ee018c-30715d0f-712e-4181-9dea-d1b82b234831-000000@ap-northeast-1.amazonses.com?part=1

      reply	other threads:[~2026-11-22  6:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-22  6:25 [PATCH] ASoC: codecs: wcd-common: bound interrupt status retries Jizhou Tong
2026-11-22  6:30 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-227766@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=fqwqf@fqwqf.xyz \
    --cc=linux-sound@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox