From: Pavel Roskin <proski@gnu.org>
To: Josh Triplett <josht@us.ibm.com>
Cc: linux-sparse@vger.kernel.org
Subject: Re: [PATCH] Recognize and ignore __alias__ and __visibility__
Date: Mon, 14 Aug 2006 15:25:29 -0400 [thread overview]
Message-ID: <1155583529.24307.1.camel@dv> (raw)
In-Reply-To: <1155570745.5410.8.camel@josh-work.beaverton.ibm.com>
On Mon, 2006-08-14 at 08:52 -0700, Josh Triplett wrote:
> Stylistically, it looks like all of the existing ignored keywords in
> this function use a single combined if condition for the underscored and
> non-underscored versions of a given keyword, rather than two separate if
> conditions. For consistency, what about something like the following
> instead:
Thanks for this improvement!
Signed-off-by: Pavel Roskin <proski@gnu.org>
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2006-08-14 19:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-13 5:51 [PATCH] Recognize and ignore __alias__ and __visibility__ Pavel Roskin
2006-08-14 15:52 ` Josh Triplett
2006-08-14 19:25 ` Pavel Roskin [this message]
2006-09-11 21:09 ` [PATCH RESEND] " Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1155583529.24307.1.camel@dv \
--to=proski@gnu.org \
--cc=josht@us.ibm.com \
--cc=linux-sparse@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox