Re: [PATCH 0/2] Improved flow graphs

[Dan Sheridan <djs@postman.org.uk>]

On Tue, 2007-05-22 at 15:11 -0700, Josh Triplett wrote:
> Dan Sheridan wrote:
> > These two patches are the first of several implementing improved graph
> > generation for Sparse.
> 
> Very nice work.  I've applied both patches in this series.

Thanks.

> I noticed one minor issue: gvpr/return-paths seems to turn some internal
> edges in functions into dotted-line return paths.

I think you are talking about the edges which connect call sites to
return sites. These are needed to keep the layout of the graph sane, but
could be made invisible. It would at least help if they looked different
to the return edges.

> Also, unprocessed graphs have now become far more messy; for instance,
> graphing validation/context.c generates numerous edges to a() and r().  Any
> way you could prevent these edges from crossing other subgraphs? 

Probably not. There's a lot of tweaking possible with weights, which
I'll experiment with a bit, but your suggestion of separate a() and r()
nodes might be simpler. Should be very easy to obtain with a gvpr
script.

	Dan.