Re: [PATCH 6/6] Add a simple test script, embed expected results into test files

[Josh Triplett <josht@linux.vnet.ibm.com>]

On Thu, 2007-06-28 at 20:59 +0200, Damien Lespiau wrote:
> I happen to have 3 patches in my tree that look like this one. I
> thought you might
> want to have a look as they appear to handle the points you were wanting to fix.
> Patch 3 is a "documentation patch" that explains what I wanted to do.
> 
> I attached those patches as gmail does not allow me to answer a thread and
> post a patch without losing its formatting.

Will review in more detail later, but at first glance this looks quite
good, and very capable.

Two minor things that jump out at me:
      * The need to specify the command line as "../sparse args $file"
        seems somewhat inelegant.  I do like the ability to specify a
        command other than sparse; for example, this could allow
        checking the output of c2xml.  However, I'd prefer not to need a
        path; how about allowing "sparse args $file"?  Also, allowing an
        alternate option "check-options" that just specifies sparse
        flags seems useful, and the default command could do something
        like "sparse $options $file"; that way, you can just say
        "check-options: -E", or "check-options: -Wthingy".
      * The need to prefix every line of output, rather than delimiting
        the start and end of the output, seems painful with large
        amounts of output.

Other than that, I really like this test suite.  Thanks!

- Josh Triplett