From: Josh Triplett <josht@linux.vnet.ibm.com>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: linux-sparse@vger.kernel.org
Subject: Re: [PATCH 3/8] integer_promotions() can't get SYM_NODE
Date: Fri, 13 Jul 2007 11:04:58 -0700 [thread overview]
Message-ID: <1184349898.2616.42.camel@josh-work.beaverton.ibm.com> (raw)
In-Reply-To: <E1I9PCB-0000EF-51@ZenIV.linux.org.uk>
On Fri, 2007-07-13 at 18:44 +0100, Al Viro wrote:
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
> evaluate.c | 9 ++-------
> 1 files changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/evaluate.c b/evaluate.c
> index 7669c9a..88435da 100644
> --- a/evaluate.c
> +++ b/evaluate.c
> @@ -98,17 +98,12 @@ static struct symbol *evaluate_string(struct expression *expr)
> return sym;
> }
>
> +/* type has come from classify_type and is an integer type */
> static inline struct symbol *integer_promotion(struct symbol *type)
> {
> struct symbol *orig_type = type;
> unsigned long mod = type->ctype.modifiers;
> - int width;
> -
> - if (type->type == SYM_NODE)
> - type = type->ctype.base_type;
> - if (type->type == SYM_ENUM)
> - type = type->ctype.base_type;
> - width = type->bit_size;
> + int width = type->bit_size;
>
> /*
> * Bitfields always promote to the base type,
In addition to SYM_NODE as mentioned in the commit message, this also
removes SYM_ENUM as classify_type handles that too. I'll append that to
the commit message.
- Josh Triplett
prev parent reply other threads:[~2007-07-13 18:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-13 17:44 [PATCH 3/8] integer_promotions() can't get SYM_NODE Al Viro
2007-07-13 18:04 ` Josh Triplett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1184349898.2616.42.camel@josh-work.beaverton.ibm.com \
--to=josht@linux.vnet.ibm.com \
--cc=linux-sparse@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).