From: Josh Triplett <josht@linux.vnet.ibm.com>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: linux-sparse@vger.kernel.org
Subject: Re: [PATCH 7/8] rewrite type_difference()
Date: Fri, 13 Jul 2007 11:16:43 -0700 [thread overview]
Message-ID: <1184350603.2616.47.camel@josh-work.beaverton.ibm.com> (raw)
In-Reply-To: <E1I9PCp-0000FJ-5s@ZenIV.linux.org.uk>
On Fri, 2007-07-13 at 18:45 +0100, Al Viro wrote:
> --- a/evaluate.c
> +++ b/evaluate.c
> @@ -621,92 +621,145 @@ static struct symbol *evaluate_ptr_add(struct expression *expr, struct symbol *c
>
> static void examine_fn_arguments(struct symbol *fn);
>
> -const char * type_difference(struct symbol *target, struct symbol *source,
> - unsigned long target_mod_ignore, unsigned long source_mod_ignore)
> +#define MOD_IGN (MOD_VOLATILE | MOD_CONST)
> +
> +const char *type_difference(struct ctype *c1, struct ctype *c2,
> + unsigned long mod1, unsigned long mod2)
[...]
> --- a/symbol.h
> +++ b/symbol.h
> @@ -245,7 +245,7 @@ extern struct symbol_list *translation_unit_used_list;
>
> extern void access_symbol(struct symbol *);
>
> -extern const char * type_difference(struct symbol *target, struct symbol *source,
> +extern const char * type_difference(struct ctype *c1, struct ctype *c2,
> unsigned long target_mod_ignore, unsigned long source_mod_ignore);
You didn't update the third and fourth arguments in this prototype.
- Josh Triplett
next prev parent reply other threads:[~2007-07-13 18:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-13 17:45 [PATCH 7/8] rewrite type_difference() Al Viro
2007-07-13 18:16 ` Josh Triplett [this message]
2007-07-13 18:19 ` Al Viro
2007-07-13 18:30 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1184350603.2616.47.camel@josh-work.beaverton.ibm.com \
--to=josht@linux.vnet.ibm.com \
--cc=linux-sparse@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).