Re: [PATCH 7/8] rewrite type_difference()

[Josh Triplett <josht@linux.vnet.ibm.com>]

On Fri, 2007-07-13 at 19:19 +0100, Al Viro wrote:
> On Fri, Jul 13, 2007 at 11:16:43AM -0700, Josh Triplett wrote:
> > On Fri, 2007-07-13 at 18:45 +0100, Al Viro wrote:
> > > --- a/evaluate.c
> > > +++ b/evaluate.c
> > > @@ -621,92 +621,145 @@ static struct symbol *evaluate_ptr_add(struct expression *expr, struct symbol *c
> > > 
> > >  static void examine_fn_arguments(struct symbol *fn);
> > > 
> > > -const char * type_difference(struct symbol *target, struct symbol *source,
> > > -	unsigned long target_mod_ignore, unsigned long source_mod_ignore)
> > > +#define MOD_IGN (MOD_VOLATILE | MOD_CONST)
> > > +
> > > +const char *type_difference(struct ctype *c1, struct ctype *c2,
> > > +	unsigned long mod1, unsigned long mod2)
> > [...]
> > > --- a/symbol.h
> > > +++ b/symbol.h
> > > @@ -245,7 +245,7 @@ extern struct symbol_list *translation_unit_used_list;
> > > 
> > >  extern void access_symbol(struct symbol *);
> > > 
> > > -extern const char * type_difference(struct symbol *target, struct symbol *source,
> > > +extern const char * type_difference(struct ctype *c1, struct ctype *c2,
> > >  	unsigned long target_mod_ignore, unsigned long source_mod_ignore);
> > 
> > You didn't update the third and fourth arguments in this prototype.
> 
> Do you want their renaming as a followup patch or as a resend?  (Or just
> rename them in the patch or upon commit - it won't clash with any later
> changes).

I'll fix them manually as part of that commit.

- Josh Triplett