From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josh Triplett Subject: Re: [PATCH 7/8] rewrite type_difference() Date: Fri, 13 Jul 2007 11:30:31 -0700 Message-ID: <1184351431.2616.50.camel@josh-work.beaverton.ibm.com> References: <1184350603.2616.47.camel@josh-work.beaverton.ibm.com> <20070713181904.GC21668@ftp.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from e34.co.us.ibm.com ([32.97.110.152]:45145 "EHLO e34.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756455AbXGMSaS (ORCPT ); Fri, 13 Jul 2007 14:30:18 -0400 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e34.co.us.ibm.com (8.13.8/8.13.8) with ESMTP id l6DIUIot006128 for ; Fri, 13 Jul 2007 14:30:18 -0400 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v8.4) with ESMTP id l6DIUHjW175428 for ; Fri, 13 Jul 2007 12:30:17 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l6DIUGd2003570 for ; Fri, 13 Jul 2007 12:30:17 -0600 In-Reply-To: <20070713181904.GC21668@ftp.linux.org.uk> Sender: linux-sparse-owner@vger.kernel.org List-Id: linux-sparse@vger.kernel.org To: Al Viro Cc: linux-sparse@vger.kernel.org On Fri, 2007-07-13 at 19:19 +0100, Al Viro wrote: > On Fri, Jul 13, 2007 at 11:16:43AM -0700, Josh Triplett wrote: > > On Fri, 2007-07-13 at 18:45 +0100, Al Viro wrote: > > > --- a/evaluate.c > > > +++ b/evaluate.c > > > @@ -621,92 +621,145 @@ static struct symbol *evaluate_ptr_add(struct expression *expr, struct symbol *c > > > > > > static void examine_fn_arguments(struct symbol *fn); > > > > > > -const char * type_difference(struct symbol *target, struct symbol *source, > > > - unsigned long target_mod_ignore, unsigned long source_mod_ignore) > > > +#define MOD_IGN (MOD_VOLATILE | MOD_CONST) > > > + > > > +const char *type_difference(struct ctype *c1, struct ctype *c2, > > > + unsigned long mod1, unsigned long mod2) > > [...] > > > --- a/symbol.h > > > +++ b/symbol.h > > > @@ -245,7 +245,7 @@ extern struct symbol_list *translation_unit_used_list; > > > > > > extern void access_symbol(struct symbol *); > > > > > > -extern const char * type_difference(struct symbol *target, struct symbol *source, > > > +extern const char * type_difference(struct ctype *c1, struct ctype *c2, > > > unsigned long target_mod_ignore, unsigned long source_mod_ignore); > > > > You didn't update the third and fourth arguments in this prototype. > > Do you want their renaming as a followup patch or as a resend? (Or just > rename them in the patch or upon commit - it won't clash with any later > changes). I'll fix them manually as part of that commit. - Josh Triplett