linux-sparse.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josh Triplett <josht@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-sparse@vger.kernel.org
Subject: [PATCH] CodingStyle: proscribe do-while without braces.
Date: Thu, 26 Jul 2007 14:37:02 -0700	[thread overview]
Message-ID: <1185485822.4459.1.camel@josh-work.beaverton.ibm.com> (raw)

Sparse warns about do-while loops without braces; Linus's rationale from the
Sparse Git changelog:
> Add warning message for naked do-while
>
> Does it necessarily make sense? Dunno, but it does tend to be bad
> practice, or at least result in code that can be hard to mentally parse.
>
> Maybe that mental parsing is just me.	 Or maybe it should be warned
> about. You decide.

Signed-off-by: Josh Triplett <josh@kernel.org>
---
 Documentation/CodingStyle |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle
index 7f1730f..f12e4b8 100644
--- a/Documentation/CodingStyle
+++ b/Documentation/CodingStyle
@@ -175,6 +175,13 @@ if (condition) {
 	otherwise();
 }
 
+This also does not apply to a do-while loop; always use braces with a do-while,
+even if it contains a single statement:
+
+do {
+	this();
+} while(condition);
+
 		3.1:  Spaces
 
 Linux kernel style for use of spaces depends (mostly) on
-- 
1.5.2.1

             reply	other threads:[~2007-07-26 21:36 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-26 21:37 Josh Triplett [this message]
2007-07-26 21:44 ` [PATCH] CodingStyle: proscribe do-while without braces Andrew Morton
2007-07-26 21:54   ` Josh Triplett
2007-07-27  0:18 ` Krzysztof Halasa
2007-07-27  0:35   ` Andrew Morton
2007-07-27 16:00     ` Krzysztof Halasa
2007-07-27 17:05       ` Josh Triplett
2007-07-27 17:44         ` Krzysztof Halasa
2007-07-27 18:27         ` Andrew Morton
2007-07-27 18:52           ` Josh Triplett
2007-07-27  0:42   ` Stefan Richter
2007-07-27  0:59     ` Andrew Morton
2007-07-27  7:41       ` Stefan Richter
2007-07-27  7:53         ` Andrew Morton
2007-07-27 17:13           ` Stefan Richter
2007-07-27  1:17     ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1185485822.4459.1.camel@josh-work.beaverton.ibm.com \
    --to=josht@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sparse@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).