From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josh Triplett Subject: [PATCH] CodingStyle: proscribe do-while without braces. Date: Thu, 26 Jul 2007 14:37:02 -0700 Message-ID: <1185485822.4459.1.camel@josh-work.beaverton.ibm.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from e31.co.us.ibm.com ([32.97.110.149]:41460 "EHLO e31.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1764507AbXGZVgj (ORCPT ); Thu, 26 Jul 2007 17:36:39 -0400 Sender: linux-sparse-owner@vger.kernel.org List-Id: linux-sparse@vger.kernel.org To: linux-kernel@vger.kernel.org Cc: Andrew Morton , Linus Torvalds , linux-sparse@vger.kernel.org Sparse warns about do-while loops without braces; Linus's rationale from the Sparse Git changelog: > Add warning message for naked do-while > > Does it necessarily make sense? Dunno, but it does tend to be bad > practice, or at least result in code that can be hard to mentally parse. > > Maybe that mental parsing is just me. Or maybe it should be warned > about. You decide. Signed-off-by: Josh Triplett --- Documentation/CodingStyle | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle index 7f1730f..f12e4b8 100644 --- a/Documentation/CodingStyle +++ b/Documentation/CodingStyle @@ -175,6 +175,13 @@ if (condition) { otherwise(); } +This also does not apply to a do-while loop; always use braces with a do-while, +even if it contains a single statement: + +do { + this(); +} while(condition); + 3.1: Spaces Linux kernel style for use of spaces depends (mostly) on -- 1.5.2.1