From: "Morten Welinder" <mwelinder@gmail.com>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: linux-sparse@vger.kernel.org
Subject: Re: sparse preprocessing confused
Date: Wed, 25 Apr 2007 19:52:12 -0400 [thread overview]
Message-ID: <118833cc0704251652r28f2431cs145a993e783a58bc@mail.gmail.com> (raw)
In-Reply-To: <20070425164355.2c250388.rdunlap@xenotime.net>
On 4/25/07, Randy Dunlap <rdunlap@xenotime.net> wrote:
> Although this may just be a case of "it's fugly, kill it".
>
> In net/core/skbuff.c (2.6.21-rc7-mm1), we have:
>
> memcpy(data + nhead, skb->head,
> #ifdef NET_SKBUFF_DATA_USES_OFFSET
> skb->tail);
> #else
> skb->tail - skb->head);
> #endif
If memcpy happens to be a macro, that is not valid C.
M.
next prev parent reply other threads:[~2007-04-25 23:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-25 23:43 sparse preprocessing confused Randy Dunlap
2007-04-25 23:52 ` Morten Welinder [this message]
2007-04-26 14:38 ` Neil Booth
2007-04-29 5:41 ` Chris Wedgwood
2007-04-29 6:36 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=118833cc0704251652r28f2431cs145a993e783a58bc@mail.gmail.com \
--to=mwelinder@gmail.com \
--cc=linux-sparse@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).