Re: [PATCH] ignore __cold__ attribute

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 871 bytes --]

On Tue, 2008-04-22 at 09:07 -0400, Pavel Roskin wrote:
> Quoting Johannes Berg <johannes@sipsolutions.net>:
> 
> > This is a new attribute in gcc 4.3, which when used and sparse is
> > compiled with gcc 4.3 leads to unknown attribute errors. Ignore it.
> 
> According to  
> http://gcc.gnu.org/onlinedocs/gcc/Function-Attributes.html, the new  
> attributes are "cold" and "hot".  I think we need them ignored both  
> with and without underscores.
> 
> The attributes indicate whether the function is likely to be executed,  
> and thus affect optimization.  There is nothing useful for sparse in  
> that information.

*Shrug*. I just wanted the kernel to work again and failed (in about 20
minutes of searching) to find a changelog for gcc mentioning this so
gave up and just added the one that the kernel uses. Want to amend the
patch?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]