From: Pavel Roskin <proski@gnu.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Josh Triplett <josh@freedesktop.org>,
linux-sparse <linux-sparse@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] ignore __cold__ attribute
Date: Tue, 22 Apr 2008 17:35:31 -0400 [thread overview]
Message-ID: <1208900131.22856.4.camel@dv> (raw)
In-Reply-To: <1208870706.31429.23.camel@johannes.berg>
On Tue, 2008-04-22 at 15:25 +0200, Johannes Berg wrote:
> *Shrug*. I just wanted the kernel to work again and failed (in about 20
> minutes of searching) to find a changelog for gcc mentioning this so
> gave up and just added the one that the kernel uses. Want to amend the
> patch?
I think this would be better. Now sparse would ignore both "cold" and
"hot", both with and without underscores. They are also added to
ident-list.h.
diff --git a/ident-list.h b/ident-list.h
index 8fcd7de..6104826 100644
--- a/ident-list.h
+++ b/ident-list.h
@@ -74,6 +74,8 @@ IDENT(__malloc__);
IDENT(nonnull); IDENT(__nonnull); IDENT(__nonnull__);
IDENT(constructor); IDENT(__constructor__);
IDENT(destructor); IDENT(__destructor__);
+IDENT(cold); IDENT(__cold__);
+IDENT(hot); IDENT(__hot__);
IDENT(cdecl); IDENT(__cdecl__);
IDENT(stdcall); IDENT(__stdcall__);
IDENT(fastcall); IDENT(__fastcall__);
diff --git a/parse.c b/parse.c
index 137ba77..877414c 100644
--- a/parse.c
+++ b/parse.c
@@ -353,6 +353,10 @@ static struct init_keyword {
{ "__constructor__", NS_KEYWORD, .op = &ignore_attr_op },
{ "destructor", NS_KEYWORD, .op = &ignore_attr_op },
{ "__destructor__", NS_KEYWORD, .op = &ignore_attr_op },
+ { "cold", NS_KEYWORD, .op = &ignore_attr_op },
+ { "__cold__", NS_KEYWORD, .op = &ignore_attr_op },
+ { "hot", NS_KEYWORD, .op = &ignore_attr_op },
+ { "__hot__", NS_KEYWORD, .op = &ignore_attr_op },
};
void init_parser(int stream)
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2008-04-22 21:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-22 10:41 [PATCH] ignore __cold__ attribute Johannes Berg
[not found] ` <20080422090739.2izftuclwocs80o4-cebfxv@fcnzpbc.arg@webmail.spamcop.net>
2008-04-22 13:25 ` Johannes Berg
2008-04-22 21:35 ` Pavel Roskin [this message]
2008-04-25 2:26 ` Josh Triplett
2008-05-02 19:42 ` Pavel Roskin
2008-06-19 5:04 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1208900131.22856.4.camel@dv \
--to=proski@gnu.org \
--cc=dwmw2@infradead.org \
--cc=johannes@sipsolutions.net \
--cc=josh@freedesktop.org \
--cc=linux-sparse@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).