linux-sparse.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Josh Triplett <josh@freedesktop.org>
Cc: linux-sparse <linux-sparse@vger.kernel.org>,
	Philipp Reisner <philipp.reisner@linbit.com>
Subject: Re: [PATCH] allow context attribute on variables
Date: Sat, 26 Apr 2008 17:50:05 +0200	[thread overview]
Message-ID: <1209225005.10943.15.camel@johannes.berg> (raw)
In-Reply-To: <48114059.6090103@freedesktop.org>

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]


> I like the idea of matching the existing attributes as closely as
> possible.  However, RCU provides a use case for distinguishing readers
> and writers: you might have a variable that you can read if you hold
> the RCU reader "lock", but you can only write if you hold a spinlock.

Oh good point. What way would you prefer? I can add another parameter to
the attribute, as in __attribute__((context(ctx,in,out,[read|write])))
(readwrite is implied), but that adds another parsing ambiguity. I have
just sent you another patch (was offline for a few days) that probably
won't apply without this, I'll fix this one and then do the other ones
on top.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

      reply	other threads:[~2008-04-26 15:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-23 12:55 [PATCH] allow context attribute on variables Johannes Berg
2008-04-25  2:22 ` Josh Triplett
2008-04-26 15:50   ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1209225005.10943.15.camel@johannes.berg \
    --to=johannes@sipsolutions.net \
    --cc=josh@freedesktop.org \
    --cc=linux-sparse@vger.kernel.org \
    --cc=philipp.reisner@linbit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).