From: Johannes Berg <johannes@sipsolutions.net>
To: Josh Triplett <josh@freedesktop.org>
Cc: linux-sparse@vger.kernel.org,
Philipp Reisner <philipp.reisner@linbit.com>
Subject: [PATCH v2 6/5] test conditional result locking
Date: Sun, 27 Apr 2008 14:45:53 +0200 [thread overview]
Message-ID: <1209300353.29025.1.camel@johannes.berg> (raw)
In-Reply-To: <1209299032.10943.71.camel@johannes.berg>
To test a function that can return a locked struct or NULL,
a macro has to be invented. Add a test case for that.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
The macro was a mess, this one's much better. The key is to pass in the
result variable and use it in __context__.
validation/context-vars.c | 29 +++++++++++++++++++++++++----
1 file changed, 25 insertions(+), 4 deletions(-)
--- sparse.orig/validation/context-vars.c 2008-04-27 14:10:37.000000000 +0200
+++ sparse/validation/context-vars.c 2008-04-27 14:41:41.000000000 +0200
@@ -1,3 +1,5 @@
+#include <stddef.h>
+
static void a(void *p) __attribute__((context(p,0,1)))
{
__context__(p,1);
@@ -159,13 +161,32 @@ static void good_locked_val(void)
;
}
+
+extern struct test *_search(int key);
+
+#define search(res, key) do { \
+ (res) = _search((key)); \
+ if (res) \
+ __context__(&(res)->lock,1);\
+ } while (0)
+
+static void test(void)
+{
+ struct test **x;
+
+ search(*x, 32);
+ if (*x)
+ unlock(*x);
+}
+
+
/*
* check-name: Check -Wcontext with lock variables
*
* check-error-start
-context-vars.c:53:7: warning: context imbalance in 'warn_lock1': wrong count at exit
-context-vars.c:53:7: context '**v+4': wanted 0, got 1
-context-vars.c:137:11: warning: context problem in 'warn_unlock': 'unlock' expected different context
-context-vars.c:137:11: context '*t+0': wanted >= 1, got 0
+context-vars.c:55:7: warning: context imbalance in 'warn_lock1': wrong count at exit
+context-vars.c:55:7: context '**v+4': wanted 0, got 1
+context-vars.c:139:11: warning: context problem in 'warn_unlock': 'unlock' expected different context
+context-vars.c:139:11: context '*t+0': wanted >= 1, got 0
* check-error-end
*/
prev parent reply other threads:[~2008-04-27 12:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-27 11:31 [PATCH 0/5] more sparse context tracking improvements Johannes Berg
2008-04-27 11:31 ` [PATCH 1/5] add __exact_context__ Johannes Berg
2008-04-27 11:31 ` [PATCH 2/5] allow context() attribute on variables Johannes Berg
2008-04-27 11:31 ` [PATCH 3/5] evaluate/expand context expressions Johannes Berg
2008-04-27 11:31 ` [PATCH 4/5] revert the conditional_context patch Johannes Berg
2008-04-27 11:31 ` [PATCH 5/5] check context expressions as expressions Johannes Berg
2008-04-27 12:23 ` [PATCH 6/5] test conditional result locking Johannes Berg
2008-04-27 12:45 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1209300353.29025.1.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=josh@freedesktop.org \
--cc=linux-sparse@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).