From: Pavel Roskin <proski@gnu.org>
To: Josh Triplett <josh@freedesktop.org>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-sparse <linux-sparse@vger.kernel.org>
Subject: Re: [PATCH] ignore __cold__ attribute
Date: Fri, 02 May 2008 15:42:33 -0400 [thread overview]
Message-ID: <1209757353.25568.2.camel@dv> (raw)
In-Reply-To: <4811413E.1080103@freedesktop.org>
On Thu, 2008-04-24 at 19:26 -0700, Josh Triplett wrote:
> Looks good to me. Could I get a signoff and commit message please?
I posted it already, but I think it was lost, so here it is again.
Ignore "cold" and "hot" attributes, which appeared in gcc 4.3
They describe how likely the function is to be executed, which can
affect optimization. Also ignore the attributes with underscores.
Signed-off-by: Pavel Roskin <proski@gnu.org>
---
ident-list.h | 2 ++
parse.c | 4 ++++
2 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/ident-list.h b/ident-list.h
index 8fcd7de..6104826 100644
--- a/ident-list.h
+++ b/ident-list.h
@@ -74,6 +74,8 @@ IDENT(__malloc__);
IDENT(nonnull); IDENT(__nonnull); IDENT(__nonnull__);
IDENT(constructor); IDENT(__constructor__);
IDENT(destructor); IDENT(__destructor__);
+IDENT(cold); IDENT(__cold__);
+IDENT(hot); IDENT(__hot__);
IDENT(cdecl); IDENT(__cdecl__);
IDENT(stdcall); IDENT(__stdcall__);
IDENT(fastcall); IDENT(__fastcall__);
diff --git a/parse.c b/parse.c
index 137ba77..877414c 100644
--- a/parse.c
+++ b/parse.c
@@ -353,6 +353,10 @@ static struct init_keyword {
{ "__constructor__", NS_KEYWORD, .op = &ignore_attr_op },
{ "destructor", NS_KEYWORD, .op = &ignore_attr_op },
{ "__destructor__", NS_KEYWORD, .op = &ignore_attr_op },
+ { "cold", NS_KEYWORD, .op = &ignore_attr_op },
+ { "__cold__", NS_KEYWORD, .op = &ignore_attr_op },
+ { "hot", NS_KEYWORD, .op = &ignore_attr_op },
+ { "__hot__", NS_KEYWORD, .op = &ignore_attr_op },
};
void init_parser(int stream)
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2008-05-02 19:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-22 10:41 [PATCH] ignore __cold__ attribute Johannes Berg
[not found] ` <20080422090739.2izftuclwocs80o4-cebfxv@fcnzpbc.arg@webmail.spamcop.net>
2008-04-22 13:25 ` Johannes Berg
2008-04-22 21:35 ` Pavel Roskin
2008-04-25 2:26 ` Josh Triplett
2008-05-02 19:42 ` Pavel Roskin [this message]
2008-06-19 5:04 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1209757353.25568.2.camel@dv \
--to=proski@gnu.org \
--cc=johannes@sipsolutions.net \
--cc=josh@freedesktop.org \
--cc=linux-sparse@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).