Re: Adding type information to instructions

[Josh Triplett <josht@linux.vnet.ibm.com>]

On Sat, 2008-07-05 at 00:43 +0100, David Given wrote:
> I've been having trouble finding the types of pseudos; the approach I've
> been using, which is to follow the chain of pseudo's definers until I
> find an instruction with enough type information to use, turns out to
> fail utterly on OP_LOAD instructions; I can't find any way of getting
> enough information from the opcode's arguments to determine the type of
> the target.
> 
> As a result, I've had to make a minor patch to the lineariser code.
> Given that the lineariser knows the information I need at the point
> where it generates the instruction, it would seem to make sense to tag
> the instruction with the type. This is made quite easy by the way that
> the lineariser has a allocate-typed-instruction function.
> 
> Patch enclosed; it's very simple.
> 
> Does this seem like a reasonable approach? Is it something that would be
> useful to have in the base builds? Are there any ramifications I should
> be aware of?

I can't think of any fundamental reason not to do this, other than the
standard reason of data structure size.  However, I'd like to hear
something from others on the list before accepting this patch.

- Josh Triplett