From: Bernd Petrovitsch <bernd@sysprog.at>
To: Christopher Li <sparse@chrisli.org>
Cc: linux-sparse@vger.kernel.org
Subject: Re: [PATCH] Fixup and cleanup of the modifier_string() function
Date: Tue, 14 Sep 2010 16:37:23 +0200 [thread overview]
Message-ID: <1284475043.6699.152.camel@thorin> (raw)
In-Reply-To: <AANLkTikOGhqVu8+A_kT=95AX=10H_pxhwqLmQr+08zzm@mail.gmail.com>
On Fre, 2010-09-03 at 02:13 -0700, Christopher Li wrote:
> On Mon, Aug 23, 2010 at 7:42 AM, Bernd Petrovitsch <bernd@sysprog.at> wrote:
> > Fixup and cleanup of the modifier_string() function
> >
> > This patch does:
> > - it fixes the modifier_string() function
> > - The array with the names is made "static".
>
> Sorry for the late reply.
No problem - August is holiday time (at least hereover) and if there are
more pressing issues.
> Your patch does not apply to the chrisl repository. I also notice that
They were against git://git.kernel.org/pub/scm/devel/sparse/sparse.git
which is listed on https://sparse.wiki.kernel.org/index.php/Main_Page.
But your patch doesn't apply against it. And it doesn't apply against
git://git.kernel.org/pub/scm/devel/sparse/chrisl/sparse.git - which
looks at the first glance identical to the above.
I found http://marc.info/?l=linux-sparse&m=126634898432123 but there is
no "chrisl" branch - at least not in the output of `git branch -a`.
What I'm doing wrong?
> if modifier
> is zero, it will return buffer without initialized. Well the modifier
Ooops, ACK.
Grrml, not the first time in my life that I forgot that.
> is not supposed
> to be zero, but still.
>
> Another thing in the patch is that I don't want to move the modifier
> bits for just the debug
> function. It is expected to have more change in the modifier bits. How about
> this patch? I start with your patch and end up like this.
Yes, the associative array is the better solution.
And the buffer overflow is also fixed.
> If that works for you, please sign it off and I will check it in.
It works for me.
Signed-off-by: Bernd Petrovitsch <bernd@sysprog.at>
Bernd
--
mobile: +43 664 4416156 http://www.sysprog.at/
Linux Software Development, Consulting and Services
next prev parent reply other threads:[~2010-09-14 14:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-20 10:33 modifier_string() inconsistency with modifiers Bernd Petrovitsch
2010-08-20 23:03 ` Christopher Li
2010-08-22 8:42 ` Bernd Petrovitsch
2010-08-22 17:25 ` Christopher Li
2010-08-23 14:42 ` [PATCH] Fixup and cleanup of the modifier_string() function (was Re: modifier_string() inconsistency with modifiers) Bernd Petrovitsch
2010-09-03 9:13 ` Christopher Li
2010-09-14 14:37 ` Bernd Petrovitsch [this message]
2010-09-15 22:52 ` [PATCH] Fixup and cleanup of the modifier_string() function Christopher Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284475043.6699.152.camel@thorin \
--to=bernd@sysprog.at \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).