From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernd Petrovitsch Subject: Re: including sparse headers in C++ code Date: Wed, 20 Oct 2010 11:39:04 +0200 Message-ID: <1287567544.7542.7.camel@thorin> References: <1286710919.24953.2.camel@thorin> <201010101352.10864.kdudka@redhat.com> <1286790249.24953.14.camel@thorin> <20101011191219.GD8537@feather> <1286981110.14103.86.camel@thorin> <20101020072945.GA3232@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from esgaroth.petrovitsch.at ([78.47.184.11]:2692 "EHLO esgaroth.petrovitsch.priv.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751003Ab0JTJj2 (ORCPT ); Wed, 20 Oct 2010 05:39:28 -0400 In-Reply-To: <20101020072945.GA3232@ZenIV.linux.org.uk> Sender: linux-sparse-owner@vger.kernel.org List-Id: linux-sparse@vger.kernel.org To: Christopher Li , Al Viro Cc: Kamil Dudka , Tomas Klacko , linux-sparse@vger.kernel.org, Josh Triplett On Mit, 2010-10-20 at 08:29 +0100, Al Viro wrote: > On Wed, Oct 13, 2010 at 04:45:10PM +0200, Bernd Petrovitsch wrote: > > > rename the local variables "true" and "false" to "if_true" and "if_false", > > respectively to not clash with the well-known "keywords" defined by C99. > > This is similar to commit 0be55c9. > > These are not keywords... Said that, things like ACK, that's why "keywords" is quoted above. > if (!cond->value) > true = false; > if (!true) > true = cond; > certainly reek of IOCCC. I'd rather avoid "if_true" as replacement, though. > If anything, true_expr and false_expr would make more sense. I have no strong feelings about the replacement and just followed the change in the referenced commit. Chris, should I respin the patch with *_expr? Bernd -- mobile: +43 664 4416156 http://www.sysprog.at/ Linux Software Development, Consulting and Services