From: "Diego Elio Pettenò" <flameeyes@gmail.com>
To: Christopher Li <sparse@chrisli.org>
Cc: Linux-Sparse <linux-sparse@vger.kernel.org>
Subject: Re: sparse, gcc 4.6 and a few build changes
Date: Wed, 13 Apr 2011 13:06:02 +0200 [thread overview]
Message-ID: <1302692762.15959.50.camel@raven.home.flameeyes.eu> (raw)
In-Reply-To: <BANLkTinOwWW0T6D+oFiNakXrc8SbpgqcpQ@mail.gmail.com>
Hi Chris,
Il giorno mer, 13/04/2011 alle 01.53 -0700, Christopher Li ha scritto:
> The series looks good except the CFLAGS over ride change.
>
> The CFLAGS obvious have two parts. Some of it can be savely
> overwrite. Some of shouldn't be overwrite otherwise sparse can't
> compile correctly.
Yes I know — that's why I used the "?=" setter: if CFLAGS is set in the
environment, it'll be used instead of the "CFLAGS ?=" line; all the +=
lines will be maintained instead. This does obviously not work if you
use "make CFLAGS=$something".
> I think it'd better seperate out the overwrite part of CFLAGS with
> the rest of CFLAGS, just like the git makefile.
I don't know much the git Makefiles, but I'll look into it; in the mean
time the other three patches should work fine by themselves.
> Some thing like the patch I attached. You might need to make some
> changes to merge with your branch.
Attachment is missing ;)
> Can you rebase your series on the sparse chrisl branch?
> http://git.kernel.org/?p=devel/sparse/chrisl/sparse.git;a=summary
It looks like no changes are needed for that at least, I'll send the
remaining three patches for now then.
--
Diego Elio Pettenò — Flameeyes
http://blog.flameeyes.eu/
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-04-13 11:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1302226355.2407.7.camel@raven.home.flameeyes.eu>
2011-04-13 8:53 ` sparse, gcc 4.6 and a few build changes Christopher Li
2011-04-13 11:06 ` Diego Elio Pettenò [this message]
2011-04-13 16:58 ` Christopher Li
2011-04-26 0:58 ` Christopher Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302692762.15959.50.camel@raven.home.flameeyes.eu \
--to=flameeyes@gmail.com \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).