From: Pekka Enberg <penberg@kernel.org>
To: linux-sparse@vger.kernel.org
Cc: Pekka Enberg <penberg@kernel.org>,
Christopher Li <sparse@chrisli.org>,
Jeff Garzik <jgarzik@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: [PATCH] sparse, llvm: Fix 'void *' pointer code generation
Date: Mon, 24 Oct 2011 14:43:39 +0300 [thread overview]
Message-ID: <1319456619-11546-1-git-send-email-penberg@kernel.org> (raw)
Sparse front-end generates SYM_PTR with SYM_BASETYPE with bit_size set to -1
for "void *" pointers. We currently map that to LLVMVoidType() but that no
longer works with LLVM Subversion trunk:
$ ./sparse-llvm validation/backend/struct.c
sparse-llvm: Type.cpp:676: static llvm::PointerType* llvm::PointerType::get(llvm::Type*, unsigned int): Assertion `isValidElementType(EltTy) && "Invalid type for pointer element!"' failed.
Aborted
Fix the issue by switching to LLVMIntType(bits_per_pointer) in
sym_basetype_type().
Cc: Christopher Li <sparse@chrisli.org>
Cc: Jeff Garzik <jgarzik@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Pekka Enberg <penberg@kernel.org>
---
sparse-llvm.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sparse-llvm.c b/sparse-llvm.c
index a85dfea..ec46a04 100644
--- a/sparse-llvm.c
+++ b/sparse-llvm.c
@@ -80,7 +80,7 @@ static LLVMTypeRef sym_basetype_type(struct symbol *sym)
} else {
switch (sym->bit_size) {
case -1:
- ret = LLVMVoidType();
+ ret = LLVMIntType(bits_in_pointer);
break;
case 8:
ret = LLVMInt8Type();
--
1.7.6.4
next reply other threads:[~2011-10-24 11:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-24 11:43 Pekka Enberg [this message]
2011-10-24 11:52 ` [PATCH] sparse, llvm: Fix 'void *' pointer code generation Linus Torvalds
2011-10-24 11:56 ` Pekka Enberg
2011-10-24 12:14 ` Jonathan Neuschäfer
2011-10-24 12:33 ` Pekka Enberg
2011-10-24 15:13 ` Jeff Garzik
2011-10-24 15:18 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319456619-11546-1-git-send-email-penberg@kernel.org \
--to=penberg@kernel.org \
--cc=jgarzik@redhat.com \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).