From: Pekka Enberg <penberg@kernel.org>
To: linux-sparse@vger.kernel.org
Cc: Pekka Enberg <penberg@kernel.org>,
Christopher Li <sparse@chrisli.org>,
Jeff Garzik <jgarzik@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: [PATCH] sparse, llvm: More comparison ops code generation
Date: Tue, 22 Nov 2011 19:40:32 +0200 [thread overview]
Message-ID: <1321983632-8458-1-git-send-email-penberg@kernel.org> (raw)
This patch implements LLVM code generation for OP_SET_LE, OP_SET_GE, OP_SET_BE,
and OP_SET_AE.
Cc: Christopher Li <sparse@chrisli.org>
Cc: Jeff Garzik <jgarzik@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Pekka Enberg <penberg@kernel.org>
---
sparse-llvm.c | 8 ++++----
validation/backend/cmp-ops.c | 20 ++++++++++++++++++++
2 files changed, 24 insertions(+), 4 deletions(-)
diff --git a/sparse-llvm.c b/sparse-llvm.c
index 6402666..700a7a4 100644
--- a/sparse-llvm.c
+++ b/sparse-llvm.c
@@ -502,10 +502,10 @@ static void output_op_binary(struct function *fn, struct instruction *insn)
target = LLVMBuildICmp(fn->builder, LLVMIntNE, lhs, rhs, target_name);
break;
case OP_SET_LE:
- assert(0);
+ target = LLVMBuildICmp(fn->builder, LLVMIntSLE, lhs, rhs, target_name);
break;
case OP_SET_GE:
- assert(0);
+ target = LLVMBuildICmp(fn->builder, LLVMIntSGE, lhs, rhs, target_name);
break;
case OP_SET_LT:
assert(!symbol_is_fp_type(insn->type));
@@ -522,10 +522,10 @@ static void output_op_binary(struct function *fn, struct instruction *insn)
target = LLVMBuildICmp(fn->builder, LLVMIntUGT, lhs, rhs, target_name);
break;
case OP_SET_BE:
- assert(0);
+ target = LLVMBuildICmp(fn->builder, LLVMIntULE, lhs, rhs, target_name);
break;
case OP_SET_AE:
- assert(0);
+ target = LLVMBuildICmp(fn->builder, LLVMIntUGE, lhs, rhs, target_name);
break;
default:
assert(0);
diff --git a/validation/backend/cmp-ops.c b/validation/backend/cmp-ops.c
index b1ad227..7bbc81c 100644
--- a/validation/backend/cmp-ops.c
+++ b/validation/backend/cmp-ops.c
@@ -18,6 +18,16 @@ static int setg(int x, int y)
return x > y;
}
+static int setle(int x, int y)
+{
+ return x <= y;
+}
+
+static int setge(int x, int y)
+{
+ return x >= y;
+}
+
static int setb(unsigned int x, unsigned int y)
{
return x < y;
@@ -28,6 +38,16 @@ static int seta(unsigned int x, unsigned int y)
return x > y;
}
+static int setbe(unsigned int x, unsigned int y)
+{
+ return x <= y;
+}
+
+static int setae(unsigned int x, unsigned int y)
+{
+ return x >= y;
+}
+
/*
* check-name: Comparison operator code generation
* check-command: ./sparsec -c $file -o tmp.o
--
1.7.6.4
next reply other threads:[~2011-11-22 17:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 17:40 Pekka Enberg [this message]
2011-11-22 17:44 ` [PATCH] sparse, llvm: More comparison ops code generation Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321983632-8458-1-git-send-email-penberg@kernel.org \
--to=penberg@kernel.org \
--cc=jgarzik@redhat.com \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox