From: Pekka Enberg <penberg@kernel.org>
To: linux-sparse@vger.kernel.org
Cc: Pekka Enberg <penberg@kernel.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Christopher Li <sparse@chrisli.org>,
Jeff Garzik <jgarzik@redhat.com>
Subject: [PATCH 1/2] sparse, llvm: Simplify output_data() type logic
Date: Fri, 8 Jun 2012 15:34:36 +0300 [thread overview]
Message-ID: <1339158877-32024-1-git-send-email-penberg@kernel.org> (raw)
Use LLVMTypeOf() in output_data() to simplify type handling logic.
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Christopher Li <sparse@chrisli.org>
Cc: Jeff Garzik <jgarzik@redhat.com>
Signed-off-by: Pekka Enberg <penberg@kernel.org>
---
sparse-llvm.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sparse-llvm.c b/sparse-llvm.c
index 9226a21..a39bc02 100644
--- a/sparse-llvm.c
+++ b/sparse-llvm.c
@@ -1192,7 +1192,7 @@ static LLVMValueRef output_data(LLVMModuleRef module, struct symbol *sym)
name = show_ident(sym->ident);
- data = LLVMAddGlobal(module, symbol_type(module, sym->ctype.base_type), name);
+ data = LLVMAddGlobal(module, LLVMTypeOf(initial_value), name);
LLVMSetLinkage(data, data_linkage(sym));
--
1.7.7.6
next reply other threads:[~2012-06-08 12:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 12:34 Pekka Enberg [this message]
2012-06-08 12:34 ` [PATCH 2/2] sparse, llvm: Fix string initializer code generation Pekka Enberg
2012-06-08 18:15 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339158877-32024-1-git-send-email-penberg@kernel.org \
--to=penberg@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=jgarzik@redhat.com \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).