From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Rostedt Subject: Re: [PATCH 7/10] compiler{,-gcc4}.h: Introduce __flatten function attribute Date: Wed, 03 Oct 2012 11:14:01 -0400 Message-ID: <1349277241.22822.176.camel@gandalf.local.home> References: <1348874411-28288-1-git-send-email-daniel.santos@pobox.com> <1348874411-28288-8-git-send-email-daniel.santos@pobox.com> <20120929002626.GD13907@jtriplet-mobl1> <50664308.6020601@att.net> <20120929005043.GD14293@jtriplet-mobl1> <20121003065959.GA4963@leaf> <506C1F8B.1070307@att.net> <1349272914.22822.169.camel@gandalf.local.home> <506C4FD0.4040307@att.net> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <506C4FD0.4040307@att.net> Sender: linux-kernel-owner@vger.kernel.org To: Daniel Santos Cc: David Rientjes , Josh Triplett , LKML , Andi Kleen , Andrea Arcangeli , Andrew Morton , Christopher Li , David Daney , David Howells , Joe Perches , Konstantin Khlebnikov , linux-sparse@vger.kernel.org, Michel Lespinasse , Paul Gortmaker , Pavel Pisa , Peter Zijlstra List-Id: linux-sparse@vger.kernel.org On Wed, 2012-10-03 at 09:46 -0500, Daniel Santos wrote: > > Please move the patch to the patch series where it is used. Otherwise it > > confuses reviewers as it did here. > Ok then, but this would also apply to the addition of these macros as well: > BUILD_BUG_ON_NON_CONST > BUILD_BUG42 > BUILD_BUG_ON_NON_CONST42 > > Should these then also be moved? If they are only used by the other patch set, sure. > Should I only CC those who have responded to these patches and whomever > is in the MAINTAINERS file then? Yep. I personally never use the get_maintainers script. I first check the MAINTAINERS file. If the subsystem I'm working on exists there, I only email those that are listed there, including any mailing lists that are mentioned (as well as LKML). If it's not listed, I then do a git log and see who does the most sign offs to changes there, and to what kind of changes. I usually ignore the trivial stuff. -- Steve