linux-sparse.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: linux-sparse@vger.kernel.org
Cc: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
	"Mitesh Shah" <mshah@teja.com>,
	"Christopher Li" <sparse@chrisli.org>,
	"Jeff Garzik" <jgarzik@redhat.com>
Subject: [PATCH 1/2] lib: rename die_if_error to error_happened
Date: Tue,  9 Oct 2012 01:17:57 +0200	[thread overview]
Message-ID: <1349738279-13253-1-git-send-email-j.neuschaefer@gmx.net> (raw)

The variable in question is set when an error message is output,
and doesn't control termination at all, so I think the new name
matches the semantics better.

Cc: Mitesh Shah <mshah@teja.com>
Cc: Christopher Li <sparse@chrisli.org>
Cc: Jeff Garzik <jgarzik@redhat.com>
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
 lib.c |    4 ++--
 lib.h |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib.c b/lib.c
index b4d3944..1172dc2 100644
--- a/lib.c
+++ b/lib.c
@@ -29,7 +29,7 @@
 #include "target.h"
 
 int verbose, optimize, optimize_size, preprocessing;
-int die_if_error = 0;
+int error_happened = 0;
 
 #ifndef __GNUC__
 # define __GNUC__ 2
@@ -131,7 +131,7 @@ void warning(struct position pos, const char * fmt, ...)
 static void do_error(struct position pos, const char * fmt, va_list args)
 {
 	static int errors = 0;
-        die_if_error = 1;
+	error_happened = 1;
 	show_info = 1;
 	/* Shut up warnings after an error */
 	max_warnings = 0;
diff --git a/lib.h b/lib.h
index 2cea252..7cde9c2 100644
--- a/lib.h
+++ b/lib.h
@@ -25,7 +25,7 @@
 #endif
 
 extern int verbose, optimize, optimize_size, preprocessing;
-extern int die_if_error;
+extern int error_happened;
 extern int repeat_phase, merge_phi_sources;
 extern int gcc_major, gcc_minor, gcc_patchlevel;
 
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2012-10-08 23:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-08 23:17 Jonathan Neuschäfer [this message]
2012-10-08 23:17 ` [PATCH 2/2] sparse, llvm: don't compile erroneous code Jonathan Neuschäfer
2012-10-09  6:30   ` Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1349738279-13253-1-git-send-email-j.neuschaefer@gmx.net \
    --to=j.neuschaefer@gmx.net \
    --cc=jgarzik@redhat.com \
    --cc=linux-sparse@vger.kernel.org \
    --cc=mshah@teja.com \
    --cc=sparse@chrisli.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).