From: Joe Perches <joe@perches.com>
To: Josh Triplett <josh@joshtriplett.org>
Cc: linux-sparse@vger.kernel.org
Subject: Re: [RFC PATCH] sparse: Add cmd line --version option
Date: Wed, 06 Mar 2013 13:57:23 -0800 [thread overview]
Message-ID: <1362607043.2093.19.camel@joe-AO722> (raw)
In-Reply-To: <20130306214550.GA8486@jtriplet-mobl1>
On Wed, 2013-03-06 at 13:45 -0800, Josh Triplett wrote:
> On Wed, Mar 06, 2013 at 09:22:58AM -0800, Joe Perches wrote:
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -1,5 +1,12 @@
> > VERSION=0.4.4
> >
> > +HAVE_GIT:=$(shell git describe >/dev/null 2>&1 && echo 'yes')
> > +ifeq ($(HAVE_GIT),yes)
> > +SPARSE_VERSION=$(shell git describe)
> > +else
> > +SPARSE_VERSION=$(VERSION)
> > +endif
> > +
>
> The "dist" target already has a call to "git describe"; could you unify
> the two? (And, ideally, avoid calling git describe twice, once for
> HAVE_GIT and once for SPARSE_VERSION?)
I think the overhead is low and not worth the bother.
Go for it if it bothers you.
next prev parent reply other threads:[~2013-03-06 21:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 17:22 [RFC PATCH] sparse: Add cmd line --version option Joe Perches
2013-03-06 21:19 ` Christopher Li
2013-03-06 21:41 ` Joe Perches
2013-03-06 21:45 ` Josh Triplett
2013-03-06 21:57 ` Joe Perches [this message]
2013-03-07 4:18 ` Chris Li
2013-03-07 4:33 ` Joe Perches
2013-03-07 5:10 ` Christopher Li
2013-03-07 4:34 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362607043.2093.19.camel@joe-AO722 \
--to=joe@perches.com \
--cc=josh@joshtriplett.org \
--cc=linux-sparse@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).