From: Johannes Berg <johannes@sipsolutions.net>
To: Josh Triplett <josh@joshtriplett.org>
Cc: Ramsay Jones <ramsay@ramsay1.demon.co.uk>,
Christopher Li <sparse@chrisli.org>,
Sparse Mailing-list <linux-sparse@vger.kernel.org>
Subject: Re: [PATCH 4/5] test-suite: Add -b option to ignore CR at eol on MinGW
Date: Tue, 21 May 2013 23:27:00 +0200 [thread overview]
Message-ID: <1369171620.10614.0.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <20130521211650.GA11463@jtriplet-mobl1> (sfid-20130521_231704_760753_CB790B00)
On Tue, 2013-05-21 at 14:16 -0700, Josh Triplett wrote:
> On Tue, May 21, 2013 at 08:18:21PM +0100, Ramsay Jones wrote:
> > Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
>
> -b doesn't just ignore CR at end of line; it would also ignore changes
> in the amount of whitespace elsewhere on the line. You might consider
> piping the input that has CRs through sed before storing it, to delete
> the CR at end of line before comparing, instead.
Or just use --strip-trailing-cr, no? Or maybe that's not available?
johannes
next prev parent reply other threads:[~2013-05-21 21:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 19:18 [PATCH 4/5] test-suite: Add -b option to ignore CR at eol on MinGW Ramsay Jones
2013-05-21 21:16 ` Josh Triplett
2013-05-21 21:27 ` Johannes Berg [this message]
2013-05-21 21:46 ` Josh Triplett
2013-05-22 21:19 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369171620.10614.0.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=josh@joshtriplett.org \
--cc=linux-sparse@vger.kernel.org \
--cc=ramsay@ramsay1.demon.co.uk \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).