From: Erico Nunes <nunes.erico@gmail.com>
To: joe@perches.com
Cc: linux-sparse@vger.kernel.org, dwmw2@infradead.org,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
Erico Nunes <nunes.erico@gmail.com>
Subject: [PATCH] jffs2: fix sparse errors: directive in argument list
Date: Sun, 17 Nov 2013 20:43:21 -0200 [thread overview]
Message-ID: <1384728201-13509-1-git-send-email-nunes.erico@gmail.com> (raw)
In-Reply-To: <CAK4VdL2nKEE+xb=HtMGNsMGNR_ivUn_WnLi7X-rrXT0fpGbSTw@mail.gmail.com>
This patch fixes the following errors reported when running sparse:
fs/jffs2/super.c:378:1: error: directive in argument list
fs/jffs2/super.c:380:1: error: directive in argument list
fs/jffs2/super.c:381:1: error: directive in argument list
fs/jffs2/super.c:383:1: error: directive in argument list
Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
---
fs/jffs2/super.c | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/fs/jffs2/super.c b/fs/jffs2/super.c
index 0defb1c..ec9e16f 100644
--- a/fs/jffs2/super.c
+++ b/fs/jffs2/super.c
@@ -361,6 +361,14 @@ MODULE_ALIAS_FS("jffs2");
static int __init init_jffs2_fs(void)
{
int ret;
+ const char desc[] = "version 2.2."
+#ifdef CONFIG_JFFS2_FS_WRITEBUFFER
+ " (NAND)"
+#endif
+#ifdef CONFIG_JFFS2_SUMMARY
+ " (SUMMARY) "
+#endif
+ " © 2001-2006 Red Hat, Inc.";
/* Paranoia checks for on-medium structures. If we ask GCC
to pack them with __attribute__((packed)) then it _also_
@@ -374,14 +382,7 @@ static int __init init_jffs2_fs(void)
BUILD_BUG_ON(sizeof(struct jffs2_raw_inode) != 68);
BUILD_BUG_ON(sizeof(struct jffs2_raw_summary) != 32);
- pr_info("version 2.2."
-#ifdef CONFIG_JFFS2_FS_WRITEBUFFER
- " (NAND)"
-#endif
-#ifdef CONFIG_JFFS2_SUMMARY
- " (SUMMARY) "
-#endif
- " © 2001-2006 Red Hat, Inc.\n");
+ pr_info("%s\n", desc);
jffs2_inode_cachep = kmem_cache_create("jffs2_i",
sizeof(struct jffs2_inode_info),
--
1.8.4.2
next prev parent reply other threads:[~2013-11-17 22:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1384719513-27386-1-git-send-email-nunes.erico@gmail.com>
2013-11-17 21:40 ` [PATCH] jffs2: fix sparse errors: directive in argument list Joe Perches
2013-11-17 22:34 ` Erico Nunes
2013-11-17 22:43 ` Erico Nunes [this message]
2013-11-17 22:45 ` Joe Perches
2013-11-17 22:53 ` Richard Weinberger
2013-11-18 1:33 ` Al Viro
2013-11-18 2:07 ` [PATCH] Clarify error on directive in macro arguments (Re: [PATCH] jffs2: fix sparse errors: directive in argument list) Greg Price
2013-11-18 2:15 ` Joe Perches
2013-11-18 2:23 ` Erico Nunes
2013-11-18 2:34 ` Al Viro
2013-11-18 4:01 ` Greg Price
2013-11-20 23:53 ` Josh Triplett
2013-11-20 23:51 ` [PATCH] jffs2: fix sparse errors: directive in argument list Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384728201-13509-1-git-send-email-nunes.erico@gmail.com \
--to=nunes.erico@gmail.com \
--cc=dwmw2@infradead.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-sparse@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).