From mboxrd@z Thu Jan 1 00:00:00 1970 From: Phil Carmody Subject: [PATCHv2 1/3] sparse: Just use simple ints for decision variables Date: Tue, 10 Jun 2014 10:54:05 +0300 Message-ID: <1402386847-23477-2-git-send-email-phil@dovecot.fi> References: <1402315082-14102-1-git-send-email-phil@dovecot.fi> <1402386847-23477-1-git-send-email-phil@dovecot.fi> Return-path: Received: from wursti.dovecot.fi ([87.106.245.223]:39518 "EHLO wursti.dovecot.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754339AbaFJHx6 (ORCPT ); Tue, 10 Jun 2014 03:53:58 -0400 In-Reply-To: <1402386847-23477-1-git-send-email-phil@dovecot.fi> Sender: linux-sparse-owner@vger.kernel.org List-Id: linux-sparse@vger.kernel.org To: sparse@chrisli.org Cc: josh@joshtriplett.org, linux-sparse@vger.kernel.org, phil@dovecot.fi The expressions are just ints, and const is pointess. Signed-off-by: Phil Carmody --- evaluate.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/evaluate.c b/evaluate.c index 6655615..9052962 100644 --- a/evaluate.c +++ b/evaluate.c @@ -917,10 +917,10 @@ static struct symbol *evaluate_binop(struct expression *expr) rtype = integer_promotion(rtype); } else { // The rest do usual conversions - const unsigned left_not = expr->left->type == EXPR_PREOP - && expr->left->op == '!'; - const unsigned right_not = expr->right->type == EXPR_PREOP - && expr->right->op == '!'; + int left_not = expr->left->type == EXPR_PREOP + && expr->left->op == '!'; + int right_not = expr->right->type == EXPR_PREOP + && expr->right->op == '!'; if ((op == '&' || op == '|') && (left_not || right_not)) warning(expr->pos, "dubious: %sx %c %sy", left_not ? "!" : "", -- 2.0.0