* [PATCH] compiler.h: Move __memory_barrier() use to compiler-intel.h
[not found] <1407797503-24727-1-git-send-email-bobby.prani@gmail.com>
@ 2014-08-11 22:51 ` Pranith Kumar
0 siblings, 0 replies; only message in thread
From: Pranith Kumar @ 2014-08-11 22:51 UTC (permalink / raw)
To: Christopher Li, H. Peter Anvin, Cesar Eduardo Barros,
Daniel Borkmann, Herbert Xu, open list, open list:SPARSE CHECKER
Commit 73679e5082012 ("compiler-intel.h: Remove duplicate definition") removed a
duplicate definition of barrier() from compiler-intel.h. This is the wrong
duplicate definition removed since __memory_barrier() is an intel compiler
specific intrinsic and should live in compiler-intel.h.
This commit reverts the previous commit and removes the definition from
compiler.h
Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
---
include/linux/compiler-intel.h | 3 +++
include/linux/compiler.h | 5 -----
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/include/linux/compiler-intel.h b/include/linux/compiler-intel.h
index ba147a1..5529c52 100644
--- a/include/linux/compiler-intel.h
+++ b/include/linux/compiler-intel.h
@@ -13,9 +13,12 @@
/* Intel ECC compiler doesn't support gcc specific asm stmts.
* It uses intrinsics to do the equivalent things.
*/
+#undef barrier
#undef RELOC_HIDE
#undef OPTIMIZER_HIDE_VAR
+#define barrier() __memory_barrier()
+
#define RELOC_HIDE(ptr, off) \
({ unsigned long __ptr; \
__ptr = (unsigned long) (ptr); \
diff --git a/include/linux/compiler.h b/include/linux/compiler.h
index d5ad7b1..bc24cad 100644
--- a/include/linux/compiler.h
+++ b/include/linux/compiler.h
@@ -160,11 +160,6 @@ void ftrace_likely_update(struct ftrace_branch_data *f, int val, int expect);
# define unlikely(x) __builtin_expect(!!(x), 0)
#endif
-/* Optimization barrier */
-#ifndef barrier
-# define barrier() __memory_barrier()
-#endif
-
/* Unreachable code */
#ifndef unreachable
# define unreachable() do { } while (1)
--
1.9.1
^ permalink raw reply related [flat|nested] only message in thread