From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabian Frederick Subject: [PATCH V2 linux-next] jffs2: fix sparse warning: unexpected unlock Date: Sun, 28 Sep 2014 21:26:32 +0200 Message-ID: <1411932392-7751-1-git-send-email-fabf@skynet.be> Return-path: Received: from mailrelay005.isp.belgacom.be ([195.238.6.171]:27593 "EHLO mailrelay005.isp.belgacom.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750947AbaI1T0y (ORCPT ); Sun, 28 Sep 2014 15:26:54 -0400 Sender: linux-sparse-owner@vger.kernel.org List-Id: linux-sparse@vger.kernel.org To: linux-kernel@vger.kernel.org Cc: linux-sparse@vger.kernel.org, Josh Triplett , Brian Norris , Fabian Frederick , David Woodhouse , linux-mtd@lists.infradead.org fs/jffs2/summary.c:846:5: warning: context imbalance in 'jffs2_sum_write_sumnode' - unexpected unlock Suggested-by: Brian Norris Suggested-by: Josh Triplett Signed-off-by: Fabian Frederick --- V2: use __must_hold instead of __releases / __acquires (suggested by Brian Norris and Josh Triplett) fs/jffs2/summary.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/jffs2/summary.c b/fs/jffs2/summary.c index c522d09..bc53854 100644 --- a/fs/jffs2/summary.c +++ b/fs/jffs2/summary.c @@ -844,6 +844,7 @@ static int jffs2_sum_write_data(struct jffs2_sb_info *c, struct jffs2_eraseblock /* Write out summary information - called from jffs2_do_reserve_space */ int jffs2_sum_write_sumnode(struct jffs2_sb_info *c) + __must_hold(&c->erase_completion_block) { int datasize, infosize, padsize; struct jffs2_eraseblock *jeb; -- 1.9.1