Hi, > Yep that's cargo-culted, but from a quick grep only msm and qxl > headers do this (the other __user annotations in uapi/drm are for > pointers, where it's correct). Adding those maintainers. Yep, those looks pointless indeed. > Also, if you use u64_to_user_ptr helper macro sparse should have > caught this (if not we'd need to improve the macro). And qxl should actually use it. Fix attached (compile-tested only so far), does that look ok? cheers, Gerd