From: Hannes Eder <hannes@hanneseder.net>
To: Kamil Dudka <kdudka@redhat.com>
Cc: Christopher Li <sparse@chrisli.org>,
sparse <linux-sparse@vger.kernel.org>
Subject: Re: [PATCH] linearize.h: sanitize header
Date: Thu, 6 Aug 2009 19:49:23 +0200 [thread overview]
Message-ID: <154e089b0908061049o714bd341v733e828166a8f604@mail.gmail.com> (raw)
In-Reply-To: <200908061927.47201.kdudka@redhat.com>
On Thu, Aug 6, 2009 at 19:27, Kamil Dudka<kdudka@redhat.com> wrote:
> On Thursday 06 of August 2009 19:10:30 Christopher Li wrote:
>> I would just apply the change to the header file and related variables.
>> The linearize.h is consider an API header file for other sparse application
>> to use. So we'd better not assume too much on the sparse caller side.
>>
>> I agree with Kamil that rename variable in linearize.c offer no real
>> benefits. I consider it more of a personal preference thing. And it is
>> internal to linearize.c. At this point renaming variable will mess up with
>> annotations. It is not good enough reason to do it just to make
>> the editor happy.
>
> Well, let's make a tradeoff - we can only change the identifiers
> in linearize.h and the corresponding identifiers in linearize.c. I admit it
> could be confusing when we have different identifiers in the prototype and
> different identifiers in the function body. New version of the patch is
> attached.
LGTM
Acked-by: Hannes Eder <hannes@hanneseder.net>
Best,
-Hannes
prev parent reply other threads:[~2009-08-06 17:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-06 9:02 [PATCH] linearize.h: sanitize header Kamil Dudka
2009-08-06 9:23 ` Hannes Eder
2009-08-06 9:30 ` Kamil Dudka
2009-08-06 9:39 ` Hannes Eder
2009-08-06 9:51 ` Kamil Dudka
2009-08-06 11:09 ` Hannes Eder
2009-08-06 17:10 ` Christopher Li
2009-08-06 17:27 ` Kamil Dudka
2009-08-06 17:49 ` Hannes Eder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154e089b0908061049o714bd341v733e828166a8f604@mail.gmail.com \
--to=hannes@hanneseder.net \
--cc=kdudka@redhat.com \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).