Re: [PATCH] sparse: gcc 4.1 warnings

["Jörn Engel" <joern@wohnheim.fh-wedel.de>]

On Mon, 10 April 2006 20:30:28 -0400, Jeff Garzik wrote:
> Morten Welinder wrote:
> >This doesn't look quite right.
> >
> >So it looks like gcc 4.1 complains over non-used values that are the
> >result of a cast.  That feels obnoxious, but in this case maybe you
> 
> Yes, it is :)  See below for vanilla sparse build under gcc 4.1...
> 
> 
> >could try just casting to void in add_ptr_list -- is the value ever
> >used?
> 
> All uses except for add_pseudo() ignore the return value.

How about making this two functions instead?  Something like

void add_ptr_list(...)
{
	(void) __add_ptr_list(...);
}

And use the __add_ptr_list version in add_pseudo().

Hmm.  Except that this is userspace and double underscores are not
allowed.  Maybe do_add_ptr_list(...) then?

And yes, this is really obnoxious.  I have read code before that
constantly does
	(void) this(...);
	(void) that(...);
and didn't like it much.  Ignoring the issue and fixing the code
checker instead might be a better idea.

Jörn

-- 
More computing sins are committed in the name of efficiency (without
necessarily achieving it) than for any other single reason - including
blind stupidity.
-- W. A. Wulf