From: Christopher Li <sparse@chrisli.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Pavel Roskin <proski@gnu.org>, linux-sparse@vger.kernel.org
Subject: Re: Feature request - allow boolean operations of undefined cpp symbols
Date: Fri, 2 Feb 2007 13:56:03 -0800 [thread overview]
Message-ID: <20070202215603.GA27667@chrisli.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0702021021570.15057@woody.linux-foundation.org>
On Fri, Feb 02, 2007 at 10:25:12AM -0800, Linus Torvalds wrote:
> No.
>
> #if SYMBOL
>
> has a very specific *problem* - it very possibly is a typo.
>
> So this is a warning I absolutely *want* for the kernel. If some other
> projects don't want it, fine, but it should be on by default as a warnign
> for potentially dangerous use of preprocessor symbols.
>
I did some trivial test:
#if SYMBOL_NOT_DEFINED
#warning "defined"
#else
#warning "not defined"
#endif
On sparse git tip, or sparse 0.2. Here is what I get:
./sparse /tmp/a.c
/tmp/a.c:5:2: warning: "not defined"
That is what Pavel wants. So Linus should complain instead.
I am confused.
Chris
next prev parent reply other threads:[~2007-02-02 22:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-02 17:37 Feature request - allow boolean operations of undefined cpp symbols Pavel Roskin
2007-02-02 18:25 ` Linus Torvalds
2007-02-02 21:56 ` Christopher Li [this message]
2007-02-02 22:30 ` Pavel Roskin
2007-02-02 22:10 ` Christopher Li
2007-02-02 22:58 ` Pavel Roskin
2007-02-02 22:45 ` Linus Torvalds
2007-04-20 10:02 ` Josh Triplett
2007-04-20 22:42 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070202215603.GA27667@chrisli.org \
--to=sparse@chrisli.org \
--cc=linux-sparse@vger.kernel.org \
--cc=proski@gnu.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).