From: Al Viro <viro@ftp.linux.org.uk>
To: Christopher Li <sparse@chrisli.org>
Cc: Pavel Roskin <proski@gnu.org>, linux-sparse@vger.kernel.org
Subject: Re: Feature request - suppress warnings for system libraries
Date: Fri, 2 Feb 2007 23:17:05 +0000 [thread overview]
Message-ID: <20070202231705.GF10050@ftp.linux.org.uk> (raw)
In-Reply-To: <20070202223155.GD27667@chrisli.org>
On Fri, Feb 02, 2007 at 02:31:55PM -0800, Christopher Li wrote:
> On Fri, Feb 02, 2007 at 05:37:45PM -0500, Pavel Roskin wrote:
> >
> > /usr/include/sys/socket.h:88:62: error: attribute
> > '__transparent_union__': ignoring attribute __transparent_union__
> > /usr/include/sys/socket.h:92:68: error: attribute
> > '__transparent_union__': ignoring attribute __transparent_union__
> > /usr/include/netdb.h:661:60: error: typename in expression
> > /usr/include/stdlib.h:72:56: error: attribute '__transparent_union__':
> > ignoring attribute __transparent_union__
>
> I see, that is because sparse does not handle attribute
> __transparent_union__ yet. We should improve sparse instead of paper
> cover the error message.
I'm not sure. __transparent_union__ is an atrocious kludge and it does
deserve a warning. So getting it to STFU on known offenders we have no
chance to fix is OK, but legitimizing that abortion is not.
> > /usr/include/regex.h:543:27: error: typename in expression
>
> Similar here, that is because gcc has this key word "restrict"
> inside bracket. Sparse know nothing about "restrict".
>
> > I'm not going to fix socket.h. I'm checking my code, not glibc.
>
> Again, we should fix sparse instead.
Unlike __transparent_union__, restrict is at least a valid C... It's not
that hard to handle, except for the shortage of bits for modifiers...
next prev parent reply other threads:[~2007-02-02 23:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-02 17:43 Feature request - suppress warnings for system libraries Pavel Roskin
2007-02-02 22:01 ` Christopher Li
2007-02-02 22:37 ` Pavel Roskin
2007-02-02 22:31 ` Christopher Li
2007-02-02 23:17 ` Al Viro [this message]
2007-02-02 23:03 ` Christopher Li
2007-02-02 23:25 ` Linus Torvalds
2007-02-03 0:30 ` Al Viro
2007-02-03 0:40 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070202231705.GF10050@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=linux-sparse@vger.kernel.org \
--cc=proski@gnu.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).