From: Christopher Li <sparse@chrisli.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Anton Altaparmakov <aia21@cam.ac.uk>, linux-sparse@vger.kernel.org
Subject: Re: Another sparse warning...
Date: Mon, 12 Feb 2007 20:21:52 -0800 [thread overview]
Message-ID: <20070213042152.GC2922@chrisli.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0702121947240.8424@woody.linux-foundation.org>
On Mon, Feb 12, 2007 at 07:48:18PM -0800, Linus Torvalds wrote:
> > When call one of those functions, it can know that function will change
> > context. That might be a way to solve the problem that some of the
> > spinlock function is not a inline function at all.
>
> I thought we did that already. I'm fairly sure I had this working at some
> point - exactly by having the calls just add up the (known) lock/unlock
> offsets.
>
You are right. It is already there. I never see it before because my ctags
get confused about the context annotation:
void __lockfunc _spin_lock(spinlock_t *lock) __acquires(lock);
It generate tags for "lock" instead of "_spin_lock".
When I look up _spin_lock, it only shows the UP version. I never see
the SMP version of the _spin_lock.
Exactly why I want to have a ctags from sparse.
Chris
next prev parent reply other threads:[~2007-02-13 4:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-12 10:23 Another sparse warning Anton Altaparmakov
2007-02-12 15:50 ` Linus Torvalds
2007-02-12 15:55 ` Anton Altaparmakov
2007-02-13 2:00 ` Christopher Li
2007-02-13 3:48 ` Linus Torvalds
2007-02-13 4:21 ` Christopher Li [this message]
2007-02-13 8:49 ` Josh Triplett
2007-02-13 8:38 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070213042152.GC2922@chrisli.org \
--to=sparse@chrisli.org \
--cc=aia21@cam.ac.uk \
--cc=linux-sparse@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).