Re: sparse segfault in kernel -mm tree

[Randy Dunlap <rdunlap@xenotime.net>]

On Tue, 6 Mar 2007 20:13:17 -0800 Randy Dunlap wrote:

> On Tue, 6 Mar 2007 19:12:53 -0800 Christopher Li wrote:
> 
> > It seems that you are missing this change:
> > 
> > user:        Christopher Li <sparse@chrisli.org>
> > date:        Thu Feb 22 18:28:23 2007 -0800
> > summary:     Fix the segfault when initializer has unknown symbol
> > 
> > diff -r 9c425042a094 -r d22e36f6c600 expand.c
> > --- a/expand.c  Wed Feb 21 14:05:52 2007 -0800
> > +++ b/expand.c  Thu Feb 22 18:28:23 2007 -0800
> > @@ -872,7 +872,7 @@ static void verify_nonoverlapping(struct
> >         struct expression *b;
> > 
> >         FOR_EACH_PTR(*list, b) {
> > -               if (a && a->ctype->bit_size && bit_offset(a) == bit_offset(b)) {
> > +               if (a && a->ctype && a->ctype->bit_size &&
> > bit_offset(a) == bit_offset(b)) {
> >                         sparse_error(a->pos, "Initializer entry defined twice");
> >                         info(b->pos, "  also defined here");
> >                         return;
> > 
> > Many be the snapshot script need a restart again?
> 
> Hi,
> OK, I hope that's it.  I'll check it out soon.
> If that doesn't fix it, I'll post the .i file.


Hi all,
Working now, thanks to Chris for his patch and noticing that I
didn't have it.  /me /kicks snapshots.  :)

Sorry about the troubles.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***