From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Jones Subject: Re: sparse segfault in kernel -mm tree Date: Tue, 6 Mar 2007 22:51:56 -0500 Message-ID: <20070307035156.GC20706@redhat.com> References: <20070305175322.cbe0bb66.rdunlap@xenotime.net> <20070306023351.GB31138@chrisli.org> <20070305210416.7b5c0a2a.rdunlap@xenotime.net> <20070306004243.lvpk4ss8w8okw4ss@webmail.spamcop.net> <20070305224025.fe867c28.rdunlap@xenotime.net> <1173205177.32333.34.camel@dv> <20070306125846.0e3a684a.rdunlap@xenotime.net> <70318cbf0703061428u138a64b2x117eebdb915be50@mail.gmail.com> <20070306190443.b8162bff.rdunlap@xenotime.net> <70318cbf0703061912k73f19092p2f74ab7d4ae80afb@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx1.redhat.com ([66.187.233.31]:52220 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161255AbXCGDwh (ORCPT ); Tue, 6 Mar 2007 22:52:37 -0500 Content-Disposition: inline In-Reply-To: <70318cbf0703061912k73f19092p2f74ab7d4ae80afb@mail.gmail.com> Sender: linux-sparse-owner@vger.kernel.org List-Id: linux-sparse@vger.kernel.org To: Christopher Li Cc: Randy Dunlap , Pavel Roskin , linux-sparse@vger.kernel.org On Tue, Mar 06, 2007 at 07:12:53PM -0800, Christopher Li wrote: > It seems that you are missing this change: > > user: Christopher Li > date: Thu Feb 22 18:28:23 2007 -0800 > summary: Fix the segfault when initializer has unknown symbol > > diff -r 9c425042a094 -r d22e36f6c600 expand.c > --- a/expand.c Wed Feb 21 14:05:52 2007 -0800 > +++ b/expand.c Thu Feb 22 18:28:23 2007 -0800 > @@ -872,7 +872,7 @@ static void verify_nonoverlapping(struct > struct expression *b; > > FOR_EACH_PTR(*list, b) { > - if (a && a->ctype->bit_size && bit_offset(a) == bit_offset(b)) { > + if (a && a->ctype && a->ctype->bit_size && > bit_offset(a) == bit_offset(b)) { > sparse_error(a->pos, "Initializer entry defined twice"); > info(b->pos, " also defined here"); > return; > > Many be the snapshot script need a restart again? Kicked. Should work again now. (For something so trivial, that thing is really high maintainence :) Dave -- http://www.codemonkey.org.uk