From: Ivo van Doorn <ivdoorn@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Pavel Roskin <proski@gnu.org>,
linux-wireless@vger.kernel.org, linux-sparse@vger.kernel.org
Subject: Re: sparse using insane amounts of memory
Date: Thu, 8 Mar 2007 19:08:40 +0100 [thread overview]
Message-ID: <200703081908.40997.IvDoorn@gmail.com> (raw)
In-Reply-To: <1173375791.3248.37.camel@johannes.berg>
On Thursday 08 March 2007 18:43, Johannes Berg wrote:
> On Thu, 2007-03-08 at 12:34 -0500, Pavel Roskin wrote:
>
> > FIELDS32 expands to some monstrosities. Look for rt2x00_bbp_write in
> > the dump. Also behold the amount of parentheses in LOWEST_BIT32.
> > That's almost certainly the culprit.
>
> And I even had CONFIG_RT2X00_DEBUG enabled so it's worse that the
> regular case.
Those checks are intended to doublecheck the register FIELD{16,32}
defines. Since all register definitions were rewritten from the legacy driver,
(legacy driver used unions and structs for all registers) some of those
defines weren't done correctly (A bitmask could for example be in binary 000110111
which is very wrong).
To check those the register checks were added to ensure the register defines
were at least correct. I am however open to suggestions on how this should be improved
and cleaned up, since it is not my favorite piece of code. ;)
Ivo
next prev parent reply other threads:[~2007-03-08 18:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-08 2:02 sparse using insane amounts of memory Johannes Berg
[not found] ` <1173319356.3546.54.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>
2007-03-08 16:33 ` Pavel Roskin
2007-03-08 16:45 ` Johannes Berg
2007-03-08 17:13 ` Pavel Roskin
2007-03-08 17:31 ` Chris Wedgwood
2007-03-08 17:43 ` Linus Torvalds
[not found] ` <1173372315.3248.19.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>
2007-03-08 17:34 ` Pavel Roskin
2007-03-08 17:42 ` Johannes Berg
2007-03-08 17:43 ` Johannes Berg
2007-03-08 18:08 ` Ivo van Doorn [this message]
2007-03-08 18:54 ` Linus Torvalds
[not found] ` <Pine.LNX.4.64.0703081023490.10832-5CScLwifNT1QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
2007-03-08 19:02 ` Sam Ravnborg
2007-03-08 19:08 ` Linus Torvalds
[not found] ` <Pine.LNX.4.64.0703081104010.10832-5CScLwifNT1QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
2007-03-10 5:05 ` Darren Jenkins
2007-03-08 19:26 ` Ivo van Doorn
2007-03-09 1:12 ` OT [Re: sparse using insane amounts of memory] Tommy Thorn
2007-03-09 2:15 ` OT David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703081908.40997.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-sparse@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).