From: Chris Wedgwood <cw@f00f.org>
To: Neil Booth <neil@daikokuya.co.uk>
Cc: Morten Welinder <mwelinder@gmail.com>,
Randy Dunlap <rdunlap@xenotime.net>,
linux-sparse@vger.kernel.org
Subject: Re: sparse preprocessing confused
Date: Sat, 28 Apr 2007 22:41:43 -0700 [thread overview]
Message-ID: <20070429054143.GA15365@tuatara.stupidest.org> (raw)
In-Reply-To: <20070426143852.GB13111@daikokuya.co.uk>
On Thu, Apr 26, 2007 at 11:38:52PM +0900, Neil Booth wrote:
> > > memcpy(data + nhead, skb->head,
> > >#ifdef NET_SKBUFF_DATA_USES_OFFSET
> > > skb->tail);
> > >#else
> > > skb->tail - skb->head);
> > >#endif
> >
> > If memcpy happens to be a macro, that is not valid C.
>
> It's undefined rather than invalid. GCC makes an effort to
> do "what you'd expect".
I think I prefer sparse breaking on things like this (so we can find
such uglies and correct them.).
next prev parent reply other threads:[~2007-04-29 5:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-25 23:43 sparse preprocessing confused Randy Dunlap
2007-04-25 23:52 ` Morten Welinder
2007-04-26 14:38 ` Neil Booth
2007-04-29 5:41 ` Chris Wedgwood [this message]
2007-04-29 6:36 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070429054143.GA15365@tuatara.stupidest.org \
--to=cw@f00f.org \
--cc=linux-sparse@vger.kernel.org \
--cc=mwelinder@gmail.com \
--cc=neil@daikokuya.co.uk \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).