From: Al Viro <viro@ftp.linux.org.uk>
To: Josh Triplett <josh@freedesktop.org>
Cc: Damien Lespiau <damien.lespiau@gmail.com>, linux-sparse@vger.kernel.org
Subject: Re: [PATCH] Fix compilation warning on 64 bits platforms
Date: Mon, 21 May 2007 01:33:18 +0100 [thread overview]
Message-ID: <20070521003318.GB4095@ftp.linux.org.uk> (raw)
In-Reply-To: <4650E7B5.4030207@freedesktop.org>
On Sun, May 20, 2007 at 05:28:37PM -0700, Josh Triplett wrote:
> Damien Lespiau wrote:
> > Fix: format '%d' expects type 'int', but argument 2 has type 'long int'
> [...]
> > @@ -461,7 +461,7 @@ const char *show_instruction(struct instruction *insn)
> > }
> >
> > if (buf >= buffer + sizeof(buffer))
> > - die("instruction buffer overflowed %d\n", buf - buffer);
> > + die("instruction buffer overflowed %d\n", (int)(buf - buffer));
>
> A cast doesn't seem like the right fix. The difference between two pointers
> has type ptrdiff_t. sizeof(ptrdiff_t) == 8 on 64-bit platforms, leading to
> the legitimate warning you saw. This cast would truncate the difference to 32
> bits. glibc supplies a "t" length modifier for ptrdiff_t, but I don't think
> sparse can't portably use that.
Not just glibc; it's in C99. So yes, I'd say we should use %td here.
next prev parent reply other threads:[~2007-05-21 0:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-21 0:04 [PATCH] Fix compilation warning on 64 bits platforms Damien Lespiau
2007-05-21 0:28 ` Josh Triplett
2007-05-21 0:33 ` Al Viro [this message]
2007-05-21 0:36 ` Josh Triplett
2007-05-22 18:06 ` Damien Lespiau
2007-05-22 21:20 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070521003318.GB4095@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=damien.lespiau@gmail.com \
--cc=josh@freedesktop.org \
--cc=linux-sparse@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).