From: Al Viro <viro@ftp.linux.org.uk>
To: Neil Booth <neil@daikokuya.co.uk>
Cc: Josh Triplett <josh@freedesktop.org>,
Segher Boessenkool <segher@kernel.crashing.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-sparse@vger.kernel.org
Subject: Re: [PATCH 16/16] fix handling of integer constant expressions
Date: Wed, 27 Jun 2007 13:19:48 +0100 [thread overview]
Message-ID: <20070627121948.GN21478@ftp.linux.org.uk> (raw)
In-Reply-To: <20070627115245.GP7590@daikokuya.co.uk>
On Wed, Jun 27, 2007 at 08:52:45PM +0900, Neil Booth wrote:
> Al Viro wrote:-
>
> >
> > sparse simply doesn't check that. We don't have anything resembling
> > support of VLA. Note that check for integer constant expression
> > has nothing to do with that;
> >
> > int x[(int)(0.6 + 0.6)];
> >
> > is valid (if stupid).
>
> It isn't valid; it fails the test twice. Both 0.6 are not "immediate
> operands of casts". Their sum is, but that's irrelevant.
> Therefore the dimension is not an ICE and a diagnostic is required.
Egads... After rereading that... What a mess.
int foo(void)
{
static int a[1][0,2];
}
is, AFAICS, allowed. Reason:
int a[0,2]
is a VLA due to 6.7.5.2[4] (0,2 is not an ICE). However, due to the language
in the same section,
int a[1][0,2]
is *not* a VLA, since (a) 2 is an ICE and (b) its element type "has a known
constant size" (it does - the value of 0,2 is certainly guaranteed to be 2).
I.e., it's VM type, but not a VLA. I.e. only the first part of 6.7.5.2[2]
applies and we are actually fine.
So we can have a static single-element array of int [0,2], but
not a plain static int [0,2]. Lovely, that...
next prev parent reply other threads:[~2007-06-27 12:19 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-24 8:05 [PATCH 16/16] fix handling of integer constant expressions Al Viro
2007-06-24 17:47 ` Al Viro
2007-06-24 18:04 ` Linus Torvalds
2007-06-24 18:35 ` Al Viro
2007-06-24 19:04 ` Linus Torvalds
2007-06-24 19:40 ` Segher Boessenkool
2007-06-24 20:38 ` Al Viro
2007-06-24 21:42 ` Neil Booth
2007-06-24 23:07 ` Al Viro
2007-06-25 6:16 ` Segher Boessenkool
2007-06-25 5:31 ` Josh Triplett
2007-06-25 19:55 ` Al Viro
2007-06-26 3:12 ` Josh Triplett
2007-06-26 22:10 ` Al Viro
2007-06-26 22:11 ` Al Viro
2007-06-26 23:32 ` Neil Booth
2007-06-27 0:18 ` Al Viro
2007-06-27 0:25 ` Linus Torvalds
2007-06-27 0:37 ` Al Viro
2007-06-27 0:29 ` Derek M Jones
2007-06-27 0:41 ` Al Viro
2007-06-27 11:52 ` Neil Booth
2007-06-27 12:19 ` Al Viro [this message]
2007-06-27 12:26 ` Neil Booth
2007-06-27 12:37 ` Al Viro
2007-06-27 12:10 ` Neil Booth
2007-06-27 12:30 ` Al Viro
2007-06-27 12:59 ` Neil Booth
2007-06-27 13:18 ` Al Viro
2007-06-27 13:35 ` Neil Booth
2007-06-27 14:06 ` Al Viro
2007-06-27 15:54 ` Al Viro
2007-06-27 14:50 ` Josh Triplett
2007-06-27 14:59 ` Al Viro
2007-06-27 16:19 ` Linus Torvalds
2007-06-27 16:34 ` Josh Triplett
2007-06-27 17:25 ` Al Viro
2007-06-27 17:29 ` Al Viro
2007-06-27 17:45 ` Linus Torvalds
2007-06-27 18:04 ` Al Viro
2007-06-27 22:50 ` Neil Booth
2007-06-28 9:08 ` Segher Boessenkool
2007-06-26 22:49 ` Josh Triplett
2007-06-25 6:13 ` Segher Boessenkool
2007-06-24 19:59 ` Al Viro
2007-06-24 18:07 ` Arnd Bergmann
2007-06-24 19:10 ` Al Viro
2007-06-24 18:18 ` Segher Boessenkool
2007-06-24 18:44 ` Al Viro
2007-06-24 19:09 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070627121948.GN21478@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=josh@freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=neil@daikokuya.co.uk \
--cc=segher@kernel.crashing.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).