From: Al Viro <viro@ftp.linux.org.uk>
To: Josh Triplett <josht@linux.vnet.ibm.com>
Cc: linux-sparse@vger.kernel.org
Subject: Re: [PATCH 2/8] clean up evaluate_sign()
Date: Fri, 13 Jul 2007 19:06:40 +0100 [thread overview]
Message-ID: <20070713180640.GB21668@ftp.linux.org.uk> (raw)
In-Reply-To: <1184349781.2616.39.camel@josh-work.beaverton.ibm.com>
On Fri, Jul 13, 2007 at 11:03:01AM -0700, Josh Triplett wrote:
> > + if (!(class & (TYPE_FLOAT|TYPE_RESTRICT))) {
> > + struct symbol *rtype = integer_promotion(ctype);
> > expr->unop = cast_to(expr->unop, rtype);
> > ctype = rtype;
> Most of this seems quite reasonable and obvious. I noticed, though,
> that this drops the handling for fouled types; did you do that
> intentionally, and if so could you elaborate on why?
They get folded with handling of restricted - classify_type() gets
TYPE_NUM|TYPE_RESTRICT|TYPE_FOULED for those.
prev parent reply other threads:[~2007-07-13 18:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-13 17:44 [PATCH 2/8] clean up evaluate_sign() Al Viro
2007-07-13 18:03 ` Josh Triplett
2007-07-13 18:06 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070713180640.GB21668@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=josht@linux.vnet.ibm.com \
--cc=linux-sparse@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).