From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH] CodingStyle: proscribe do-while without braces. Date: Fri, 27 Jul 2007 11:27:23 -0700 Message-ID: <20070727112723.131753f9.akpm@linux-foundation.org> References: <1185485822.4459.1.camel@josh-work.beaverton.ibm.com> <20070726173501.9ba466ba.akpm@linux-foundation.org> <1185555916.2642.8.camel@josh-work.beaverton.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from smtp2.linux-foundation.org ([207.189.120.14]:42632 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756600AbXG0S1j (ORCPT ); Fri, 27 Jul 2007 14:27:39 -0400 In-Reply-To: <1185555916.2642.8.camel@josh-work.beaverton.ibm.com> Sender: linux-sparse-owner@vger.kernel.org List-Id: linux-sparse@vger.kernel.org To: Josh Triplett Cc: Krzysztof Halasa , linux-kernel@vger.kernel.org, Linus Torvalds , linux-sparse@vger.kernel.org On Fri, 27 Jul 2007 10:05:16 -0700 Josh Triplett wrote: > > Sparse warnings... I think it shouldn't complain either, unless > > called with extra parameter. > > Good point; Sparse shouldn't warn about this by default. I've turned > that off in latest Sparse from Git, so you need to give -Wdo-while or > -Wall to get warnings about that. However, the kernel gives -Wall, so > you'll still see the warnings there. I believe reeducating sparse was the best fix here. I think I'll now have a quiet accident with codingstyle-proscribe-do-while-without-braces.patch