linux-sparse.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Robin Getz <rgetz@blackfin.uclinux.org>
To: Josh Triplett <josht@linux.vnet.ibm.com>
Cc: Mike Frysinger <vapier.adi@gmail.com>, linux-sparse@vger.kernel.org
Subject: Re: specifying custom attributes
Date: Thu, 2 Aug 2007 23:41:51 -0400	[thread overview]
Message-ID: <200708022341.51682.rgetz@blackfin.uclinux.org> (raw)
In-Reply-To: <1186102384.3081.39.camel@josh-work.beaverton.ibm.com>

On Thu 2 Aug 2007 20:53, Josh Triplett pondered:
> On Thu, 2007-08-02 at 18:53 -0400, Mike Frysinger wrote:
> > the Blackfin port has a few custom gcc attributes that annoys sparse:
> > include/asm/uaccess.h:63:77: error: attribute 'l1_text': unknown
> attribute
> > 
> > is there a way from the cmdline to specify a custom list of OK
> > attributes ?  i feel like adding these processor-specific attributes
> > to the source code may not be the way you guys wish to go ...
> 
> Currently no.  It might make sense to add a way to turn off the "unknown
> attribute" warning, like GCC's -Wno-attributes.

I'm not sure that helps. (if it is just a global turn it off).

We would like :
 - (a) not to get false assertions (when 'l1_text' is used)
 - to get proper assertions when:
    - (b) someone does a typo (when 'l1_test' is used)
    - (c) compiled on a system which doesn't support this (like x86) 
          to make sure we didn't polute anything we should not have

Adding things to the source will cause c to fail.
using something like -Wno-attributes will cause b to fail (unless you were 
thinking it would take a list on the command line)

-Wno-attributes foo,bar,l1_text

?

-Robin

      reply	other threads:[~2007-08-03  3:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-02 22:53 specifying custom attributes Mike Frysinger
2007-08-03  0:53 ` Josh Triplett
2007-08-03  3:41   ` Robin Getz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200708022341.51682.rgetz@blackfin.uclinux.org \
    --to=rgetz@blackfin.uclinux.org \
    --cc=josht@linux.vnet.ibm.com \
    --cc=linux-sparse@vger.kernel.org \
    --cc=vapier.adi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).