From: Sam Ravnborg <sam@ravnborg.org>
To: "Randy.Dunlap" <rdunlap@xenotime.net>
Cc: linux-sparse@vger.kernel.org
Subject: Re: what's with "symbol blah was not declared"
Date: Fri, 31 Aug 2007 06:16:27 +0200 [thread overview]
Message-ID: <20070831041627.GA22695@uranus.ravnborg.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0708302100090.26586@shark.he.net>
On Thu, Aug 30, 2007 at 09:05:34PM -0700, Randy.Dunlap wrote:
>
> e.g., linux kernel source code: init/do_mounts.c, line 23 is:
>
> int __initdata rd_doload;
>
>
> and sparse (snapshot of 2007-08-31) says:
>
> init/do_mounts.c:23:16: warning: symbol 'rd_doload' was not declared.
> Should it be static?
IIRC this is because sparse did not see a "extern int rd_doload; in a .h file so
the symbol is most probarly not used outside do_mounts.c.
So it give a hint that this symbol could be made static.
Sam
prev parent reply other threads:[~2007-08-31 4:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-31 4:05 what's with "symbol blah was not declared" Randy.Dunlap
2007-08-31 4:16 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070831041627.GA22695@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-sparse@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).