* what's with "symbol blah was not declared"
@ 2007-08-31 4:05 Randy.Dunlap
2007-08-31 4:16 ` Sam Ravnborg
0 siblings, 1 reply; 2+ messages in thread
From: Randy.Dunlap @ 2007-08-31 4:05 UTC (permalink / raw)
To: linux-sparse
e.g., linux kernel source code: init/do_mounts.c, line 23 is:
int __initdata rd_doload;
and sparse (snapshot of 2007-08-31) says:
init/do_mounts.c:23:16: warning: symbol 'rd_doload' was not declared. Should it be static?
thanks,
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: what's with "symbol blah was not declared"
2007-08-31 4:05 what's with "symbol blah was not declared" Randy.Dunlap
@ 2007-08-31 4:16 ` Sam Ravnborg
0 siblings, 0 replies; 2+ messages in thread
From: Sam Ravnborg @ 2007-08-31 4:16 UTC (permalink / raw)
To: Randy.Dunlap; +Cc: linux-sparse
On Thu, Aug 30, 2007 at 09:05:34PM -0700, Randy.Dunlap wrote:
>
> e.g., linux kernel source code: init/do_mounts.c, line 23 is:
>
> int __initdata rd_doload;
>
>
> and sparse (snapshot of 2007-08-31) says:
>
> init/do_mounts.c:23:16: warning: symbol 'rd_doload' was not declared.
> Should it be static?
IIRC this is because sparse did not see a "extern int rd_doload; in a .h file so
the symbol is most probarly not used outside do_mounts.c.
So it give a hint that this symbol could be made static.
Sam
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-08-31 4:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-31 4:05 what's with "symbol blah was not declared" Randy.Dunlap
2007-08-31 4:16 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).