From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: what's with "symbol blah was not declared" Date: Fri, 31 Aug 2007 06:16:27 +0200 Message-ID: <20070831041627.GA22695@uranus.ravnborg.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from pasmtpb.tele.dk ([80.160.77.98]:34934 "EHLO pasmtpB.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750701AbXHaEPG (ORCPT ); Fri, 31 Aug 2007 00:15:06 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-sparse-owner@vger.kernel.org List-Id: linux-sparse@vger.kernel.org To: "Randy.Dunlap" Cc: linux-sparse@vger.kernel.org On Thu, Aug 30, 2007 at 09:05:34PM -0700, Randy.Dunlap wrote: > > e.g., linux kernel source code: init/do_mounts.c, line 23 is: > > int __initdata rd_doload; > > > and sparse (snapshot of 2007-08-31) says: > > init/do_mounts.c:23:16: warning: symbol 'rd_doload' was not declared. > Should it be static? IIRC this is because sparse did not see a "extern int rd_doload; in a .h file so the symbol is most probarly not used outside do_mounts.c. So it give a hint that this symbol could be made static. Sam